TeamInklings/OctobotStealth
TeamInklings/OctobotStealth
Archived
1
0
Fork 0
forked from TeamInklings/Octobot
Code Pull requests Wiki Activity Actions
290 commits 1 branch 0 tags 2.8 MiB
Commit graph

150 commits

Author SHA1 Message Date
Octol1ttle
9429dfe8d8
Fix "No operation context has been set for this scope." crash on startup (#293) 
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-26 15:35:31 +05:00
Macintxsh
e76fccd622
Rename currentMember to botMember (#291) 
Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-03-24 21:40:04 +03:00
Octol1ttle
171cfaea1a
Add 'ModeratorRole' guild setting (#290) 
Octobot has various moderation commands such as /ban, /mute, /kick.
These commands add multiple features to Discord's built-in functions
(such as durations and logging). Some admins may want to force their
users to use Octobot's commands instead of Discord UI functions.
However, due to the current design, they can't take away the permissions
as that remove access to the respective command.

This PR adds the `ModeratorRole` option which allows anyone who has
`ManageMessages` permission and the role to perform any moderator
action.

If the role is not set, the Discord permissions are checked instead. If
the user doesn't have the role, but has the permission, they can still
run the command.

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-24 23:29:10 +05:00
Octol1ttle
5e4d0a528c
Split message clear log when cleared messages are too long (#288) 
This change makes Octobot split the message clear log into multiple
messages when the combined length of cleared messages exceeds the
maximum length for an embed description.

Closes #180
 2024-03-24 15:48:32 +00:00
Octol1ttle
c2f7aadaea
Do not use ResultError#IsUserOrEnvironmentError (#289) 
In LoggerExtensions#LogResult we skip logging the result if the error is
"user or environment error". What matches that criteria is defined by
Remora's implementation.

However, none of errors defined by the implementation should *ever* happen or be ignored:
* CommandNotFoundError: The client shouldn't send us non-existing
commands. This *can* happen because the client's command list can get
out of sync with the server's, but this happens rarely.
* AmbiguousCommandInvocationError: We don't have commands that would
trigger this error
* RequiredParameterValueMissingError: The client shouldn't send us
commands without required paremeters
* ParameterParsingError: See #220
* ConditionNotSatisfiedError: The client shouldn't send us commands that
don't satisfy our conditions

Closes #220
 2024-03-24 15:38:51 +00:00
Octol1ttle
844615e8bf
fix: do not use RepositoryUrl from GitInfo (#287) 
GitInfo's `RepositoryUrl` string depends on origin URL, which is
unvalidated user input that isn't even guaranteed to exist. This can
cause issues that are almost impossible to
debug

Closes #281
 2024-03-24 17:39:26 +05:00
Macintxsh
a9509deb1c
Don't use BannedUntil in MemberData.<init> (#286) 
Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-03-24 13:11:00 +03:00
Macintxsh
ac8621a2ec
Pre-Wiki Update (#285) 
This PR has been opened to finally update Octobot's Wiki.

Current changes summary:
- correct minor spelling issues in some command descriptions
- /about: add Octobot's Wiki button

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-03-23 21:45:39 +03:00
Octol1ttle
e0232f6008
Merge some sequential 'if' statements (#284) 
i thought there would be a lot of statements that could be merged, but
these are only ones I could find, apparently

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-21 21:31:17 +05:00
Octol1ttle
a80debf1b1
Use Result.Success property instead of Result.FromSuccess() (#283) 
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-21 20:55:34 +05:00
Octol1ttle
309d900067
Log result failures with stack traces (#282) 
This feature will improve the debugging experience for developers by
providing the information about *where exactly* a result has failed

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-20 18:08:16 +00:00
Octol1ttle
5cc04e9cc3
Change position of "Jump to ..." action for better consistency (#279) 
This will better align with how a normal moderator would respond to the
log:

Before: "see log" -> "jump to message without knowing what changed" ->
"read message diff"
After: "see log" -> "read message diff" -> "jump to message for context"

In addition, the change improves consistency with how reminders are
shown.

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-20 22:34:22 +05:00
Octol1ttle
0a930dcab1
Allow using expression-bodied properties (#280) 
This change significantly reduces the code space used by properties
while maintaining clarity on types. Since only properties are allowed to
use expression bodies, it is clear to developers that what they are
looking at is a property or not

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-20 21:08:59 +05:00
Macintxsh
ca49231c86
Disable issue report button if dirty version detected (#275) 
In this PR, I'm disabling the Report Issue button if a "dirty" version
is detected. This is done just in case so that "smart" developers don't
accidentally report a bug that they themselves created.

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-03-20 15:59:25 +03:00
Macintxsh
ecb92a318c
Fix /ping not showing correct locale (#276) 
yeah...

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-03-20 11:22:54 +00:00
Macintxsh
cd75780582
Add "Member left" message (#234) 
Closes #231

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
Signed-off-by: Macintxsh <95250141+mctaylors@users.noreply.github.com>
 2024-03-20 11:18:40 +00:00
Macintxsh
2342116e87
Add GitInfo NuGet package (#268) 
In this PR, I added a NuGet package called GitInfo. It can replace
Octobot.RepositoryUrl and display the bot version as the current branch
and commit.

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
Signed-off-by: Macintxsh <95250141+mctaylors@users.noreply.github.com>
 2024-03-19 20:51:32 +03:00
Macintxsh
771750c922
Rename locale Sound to Loaded for clarity (#270) 
If you go through the locales, sooner or later you will notice `Sound*`,
which is used in `GuildLoadedResponder.cs`. A new contributor (most
likely) will not understand what it is used for at once, because we use
`$"Loaded{i}".Localized()` instead of `Messages.Sound*` directly. Also,
if you change the locale's value, for example the same "Loaded!",
`Sound` will not fit anymore, because "Loaded!" is not a sound, but a
phrase.

Other suggestions are welcome.

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-03-18 21:27:35 +03:00
Macintxsh
1894b063ae
Fix auto-unban log spam (#271) 
Closes #255

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-03-18 21:26:04 +03:00
Macintxsh
398abad277
Remove unused IDiscordRestChannelAPI in ToolsCommandGroup (#273) 
Signed-off-by: Macintxsh <95250141+mctaylors@users.noreply.github.com>
 2024-03-18 23:23:42 +05:00
Macintxsh
5105b43eff
Add WelcomeMessagesChannel setting (#269) 
Closes #232

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-03-18 11:42:37 +03:00
Macintxsh
62709d927b
Add time format example to the description of commands that use TimeSpan. (#267) 
This PR was made to help users who are trying /remind for the first time
by showing an example of the correct time format in the description.

---------

Signed-off-by: Macintxsh <95250141+mctaylors@users.noreply.github.com>
Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-03-17 16:46:53 +03:00
Macintxsh
8eed295fcd
Add /8ball command (#264) 
@neroduckale was bored so I made this feature.

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
Signed-off-by: Macintxsh <95250141+mctaylors@users.noreply.github.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-13 20:40:29 +03:00
Octol1ttle
d39303560d
Make LogAction return void (#261) 
1) the method isn't actually async lulw
2) it always returns success, so might as well just be void

reduces complexity by a bit

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-02-06 18:39:20 +00:00
Octol1ttle
58bd439aa7
Revert "Add profiler base" (#260) 
Reverts TeamOctolings/Octobot#235
See #244
 2024-02-06 21:35:33 +03:00
dependabot[bot]
5483bbd203
Bump the remora group with 4 updates (#259) 2024-02-06 12:09:26 +00:00
Macintxsh
290449077a
Use TimeSpanParser.TryParse instead of ParseTimeSpan (#257) 
The ParseTimeSpan method is not needed because we no longer use the
quirky (IMO) and long
`Parser.TryParseAsync(from).AsTask().GetAwaiter().GetResult()` to parse
TimeSpan

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-01-28 21:36:29 +03:00
Macintxsh
f034ede58d
Parry "лан" flooders (#256) 
Signed-off-by: Macintxsh <95250141+mctaylors@users.noreply.github.com>
 2024-01-28 15:27:21 +03:00
Macintxsh
af84f8853a
Add /editremind (#247) 
In this PR, I'm adding a command to modify existing reminders. This can
be useful if you, for example, got the name a bit wrong or set the wrong
reminder time. Just use /editremind and recreating the reminder from
scratch will no longer be necessary.

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-01-27 15:50:27 +03:00
Macintxsh
7e9c08cab7
Don't use Option attribute in ExecuteBanAsync method (#252) 
https://github.com/TeamOctolings/Octobot/issues/246#issuecomment-1912579699
> The `Option` attribute also somehow affects the command update
behavior. I'll get rid of it then.

Closes #246

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-01-27 15:06:10 +03:00
Macintxsh
83e2c5040e
Remove mctaylors.ru mentions (#251) 
Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-01-22 20:47:53 +05:00
Macintxsh
e01fde83c6
Use custom TimeSpanParser (#223) 
Closes #154

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-31 12:27:00 +00:00
Octol1ttle
894e819865
Fix newline in LogResult (#245) 
Fixes an issue on Windows that would cause the `ResultErrorMessage` to
be unindented.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-31 13:42:59 +03:00
Macintxsh
285763d50d
/userinfo: Show if the user was kicked (#242) 
Closes #241 

Updates:
- Show if the user was kicked by [adding "Kicked" parameter to
MemberData](https://github.com/LabsDevelopment/Octobot/issues/241)
- Change `mctaylors-ru`'s `UserInfoBannedPermanently` string to be
different from `UserInfoBanned`
- Finally add `AppendPunishmentsInformation` method to avoid Cognitive
Complexity
- Use MemberData to check if the user was banned
- Rename variable `isMuted` to `wasMuted` to be consistent with other
variable names

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-21 20:35:10 +05:00
Octol1ttle
7d9a85d815
Add profiler base (#235) 
This PR adds the base classes required for profiling code inside of
Octobot. The implementation of the profiler is similar to Minecraft,
however it is more detailed and provides per-event logs for each event.
This PR does not change any code to be profiled and this is intentional.
Changes required for profiling will come as separate PRs, one for
commands, one for responders, and one for background services.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-20 22:59:17 +05:00
Octol1ttle
d4871bb23d
Use AddFromAssembly for responders and command groups (#240) 
now we don't have to explicitly type out command groups woooo

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-20 20:48:32 +03:00
Octol1ttle
21f200c988
Merge BackgroundGuildDataSaverService into GuildDataService (#239) 
Title. idk why I didn't think of this before.
Also, GuildDataService is now properly registered as an IHostedService,
so it receives start & shutdown events. So this PR gets rid of the
workaround that was needed for save-on-shutdown to function

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-20 20:08:56 +03:00
Octol1ttle
bd4c5b26da
Remove "extends IHostedService" from classes where it's not required (#236) 
Originally, these classes were services because I thought that all
DI-resolvable classes need to be services. However, this is not true, so
we can make these classes (notably Utility and GuildDataService) not
extend anything. `UtilityService` was renamed to `Utility` for
simplicity

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-20 19:33:52 +03:00
Macintxsh
6688481093
/about: Show Discord bot username instead of hardcoded one (#230) 
In this PR, I made it so that in the Author field instead of the
hardcoded name was the name of the Discord bot. This was done to match
the icon next to it in the same field.

Replaces #224

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-20 16:25:13 +00:00
Octol1ttle
74e32dee9b
Use collection expressions in more places (#238) 
ReSharper inspections have been updated, causing new warnings to appear
in the codebase. This time, the "Use collection expressions" inspection
has been enabled for usecases where the collection is not empty. This PR
fixes the check failures caused by this inspection.
 2023-12-20 19:23:37 +03:00
Macintxsh
f79968fdc2
/about: Use Markdown.Hyperlink instead of custom extension (#229) 
Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-19 15:32:11 +05:00
Macintxsh
c0b43c6a18
/about: Show link to GitHub profile if Discord member wasn't found (#226) 
In this PR, the behavior of the developer list display in /about has
been changed. Now, if a developer is not on the same server where the
/about command was executed, their username will have a link to their
GitHub profile.

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-18 14:26:08 +05:00
Macintxsh
4dc460a269
Add issue button w/ some button updates (#221) 
In this PR, I've added a "Report an issue" button and a few more
button-related changes:
- Add "Report an issue" button
- Add icon for "Octobot's source code"
- Rename `AboutTitleRepository` to `ButtonOpenRepository`
- Rename `OpenEventInfoButton` to `ButtonOpenEventInfo` to be consistent
with other language string names
- Rename `ColorsList.cs` to `Miscellaneous.cs`
- Add public const strings in `Octobot.cs` to get repository & issues links

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-17 21:35:09 +03:00
neroduckale
4581b402aa
Do not log messages edited by bots (#202) 
If the author of the edited message is a bot, then Octobot won't log the edit
 2023-12-17 22:02:50 +05:00
Macintxsh
2dc5220f46
/about: Add repository link button (#218) 
In this PR, I moved the repository link from the embed to a button in
/about command for better UI/UX

---------

Signed-off-by: Macintxsh <95250141+mctaylors@users.noreply.github.com>
 2023-12-17 16:49:44 +00:00
Macintxsh
541e18fff0
Add ChannelApiExtensions (#217) 
This PR adds an extension method to make it easier to pass Result<Embed> to CreateMessageAsync

---------

Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-17 21:47:52 +05:00
Macintxsh
9a23e1d533
FeedbackServiceExtensions: Add FeedbackMessageOptions support (#219) 
Required for #218
 2023-12-17 20:44:18 +05:00
neroduckale
59c2c5eada
Add link to original message for activated reminders and /listremind (#203) 2023-12-11 23:38:26 +03:00
Macintxsh II
eeaff23fb5
Rewrite music list (#210) 
Changes:
- Use timestamps from
[Splatunes](https://splatoonwiki.org/wiki/Splatune_(Splatoon_Original_Soundtrack))
- Increase track count to 20
- Replace Calamari Inkantation 3MIX with OG Calamari Inkantation due to long
duration

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-08 16:15:44 +05:00
Macintxsh II
42ab11d253
Rename "Event details" button to "Open Event Info" (#209) 
The correct phrasing used by Discord is "Event Info"

![image](https://github.com/LabsDevelopment/Octobot/assets/95250141/8165b70d-4c81-4b85-8251-db2de6a7f4ca)

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-08 16:06:50 +05:00