TeamInklings/OctobotStealth
TeamInklings/OctobotStealth
Archived
1
0
Fork 0
forked from TeamInklings/Octobot
Code Pull requests Wiki Activity Actions

Allow using expression-bodied properties (#280)

Browse source 
This change significantly reduces the code space used by properties
while maintaining clarity on types. Since only properties are allowed to
use expression bodies, it is clear to developers that what they are
looking at is a property or not

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
This commit is contained in:
Octol1ttle 2024-03-20 21:08:59 +05:00 committed by GitHub
parent ca49231c86
commit 0a930dcab1
Signed by: GitHub
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 43 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.editorconfig
View file

@ -42,7 +42,7 @@ csharp_space_between_square_brackets = false
csharp_style_expression_bodied_accessors = false:warning
csharp_style_expression_bodied_constructors = false:warning
csharp_style_expression_bodied_methods = false:warning
csharp_style_expression_bodied_properties = false:warning
csharp_style_expression_bodied_properties = true:warning
csharp_style_namespace_declarations = file_scoped:warning
csharp_style_prefer_utf8_string_literals = true:warning
csharp_style_var_elsewhere = true:warning

48
src/BuildInfo.cs
View file

@ -2,51 +2,15 @@
public static class BuildInfo
{
public static string RepositoryUrl
{
get
{
return ThisAssembly.Git.RepositoryUrl;
}
}
public static string RepositoryUrl => ThisAssembly.Git.RepositoryUrl;
public static string IssuesUrl
{
get
{
return $"{RepositoryUrl}/issues";
}
}
public static string IssuesUrl => $"{RepositoryUrl}/issues";
private static string Commit
{
get
{
return ThisAssembly.Git.Commit;
}
}
private static string Commit => ThisAssembly.Git.Commit;
private static string Branch
{
get
{
return ThisAssembly.Git.Branch;
}
}
private static string Branch => ThisAssembly.Git.Branch;
public static bool IsDirty
{
get
{
return ThisAssembly.Git.IsDirty;
}
}
public static bool IsDirty => ThisAssembly.Git.IsDirty;
public static string Version
{
get
{
return IsDirty ? $"{Branch}-{Commit}-dirty" : $"{Branch}-{Commit}";
}
}
public static string Version => IsDirty ? $"{Branch}-{Commit}-dirty" : $"{Branch}-{Commit}";
}