TeamInklings/OctobotStealth
TeamInklings/OctobotStealth
Archived
1
0
Fork 0
forked from TeamInklings/Octobot
Code Pull requests Wiki Activity Actions
290 commits 1 branch 0 tags 2.8 MiB
Commit graph

14 commits

Author SHA1 Message Date
Octol1ttle
c2f7aadaea
Do not use ResultError#IsUserOrEnvironmentError (#289) 
In LoggerExtensions#LogResult we skip logging the result if the error is
"user or environment error". What matches that criteria is defined by
Remora's implementation.

However, none of errors defined by the implementation should *ever* happen or be ignored:
* CommandNotFoundError: The client shouldn't send us non-existing
commands. This *can* happen because the client's command list can get
out of sync with the server's, but this happens rarely.
* AmbiguousCommandInvocationError: We don't have commands that would
trigger this error
* RequiredParameterValueMissingError: The client shouldn't send us
commands without required paremeters
* ParameterParsingError: See #220
* ConditionNotSatisfiedError: The client shouldn't send us commands that
don't satisfy our conditions

Closes #220
 2024-03-24 15:38:51 +00:00
Octol1ttle
a80debf1b1
Use Result.Success property instead of Result.FromSuccess() (#283) 
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-21 20:55:34 +05:00
Octol1ttle
309d900067
Log result failures with stack traces (#282) 
This feature will improve the debugging experience for developers by
providing the information about *where exactly* a result has failed

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-20 18:08:16 +00:00
Octol1ttle
894e819865
Fix newline in LogResult (#245) 
Fixes an issue on Windows that would cause the `ResultErrorMessage` to
be unindented.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-31 13:42:59 +03:00
Macintxsh
f79968fdc2
/about: Use Markdown.Hyperlink instead of custom extension (#229) 
Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-19 15:32:11 +05:00
Macintxsh
c0b43c6a18
/about: Show link to GitHub profile if Discord member wasn't found (#226) 
In this PR, the behavior of the developer list display in /about has
been changed. Now, if a developer is not on the same server where the
/about command was executed, their username will have a link to their
GitHub profile.

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-18 14:26:08 +05:00
Macintxsh
541e18fff0
Add ChannelApiExtensions (#217) 
This PR adds an extension method to make it easier to pass Result<Embed> to CreateMessageAsync

---------

Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-17 21:47:52 +05:00
Macintxsh
9a23e1d533
FeedbackServiceExtensions: Add FeedbackMessageOptions support (#219) 
Required for #218
 2023-12-17 20:44:18 +05:00
Macintxsh II
4c50bdaff7
Bump .NET version to 8.0 (#207) 
Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-04 20:18:56 +05:00
Macintxsh II
18cdc63883
Add StringBuilder & Markdown extensions (#206) 
In this PR, I have added StringBuilder extensions to avoid `.Append`
reuse such as `.Append("- ").AppendLine()`

Closes #205

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-04 17:09:47 +03:00
Octol1ttle
5f0d806213
Use IFeedbackService interface instead of implementation (#178) 
This PR replaces usages of the `FeedbackService` implementation with the
`IFeedbackService` interface. Using concrete implementations breaks the
whole point of dependency injection, so it doesn't make sense to use
them
 2023-11-04 23:28:22 +05:00
Octol1ttle
fb3aebb1e0
Notify user when a command execution error occurs (#171) 
With this PR, whenever command execution fails, the user will get an
error message with details of the error that can be passed on to
developers

An unrelated minor change: errors caused by task cancellations will no
longer be logged

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
Signed-off-by: mctaylors <mctaylxrs@outlook.com>
 2023-10-26 14:54:15 +00:00
Octol1ttle
67d44ff835
Sanitize input text in message edit log (#162) 
This PR fixes an issue that caused syntax highlighting to be applied to
incorrect lines in the message edit log. The fix is to prepend a
zero-width space before every line of input text. This prevents Discord
from highlighting the line when it wasn't edited
 2023-10-12 21:51:51 +05:00
Octol1ttle
e6f53b13f0
Split extension methods into separate classes (#161) 
This PR splits the extension methods contained in `Extensions.cs` into
separate classes in the `Octobot.Extensions` namespace. This was done
for multiple reasons:
1) The `Extensions.cs` violates SRP (Single Responsibility Principle) -
it takes upon itself every extension method for many types
2) Having a separate class for each extended type is a standard practice
- take a look at
[Remora.Discord](https://github.com/Remora/Remora.Discord/tree/main/Backend/Remora.Discord.Rest/Extensions)
or [osu!](https://github.com/ppy/osu/tree/master/osu.Game/Extensions)
3) Having all extension methods in one file makes it hard to find the
method you want
 2023-10-12 15:37:25 +00:00