TeamInklings/OctobotStealth
TeamInklings/OctobotStealth
Archived
1
0
Fork 0
forked from TeamInklings/Octobot
Code Pull requests Wiki Activity Actions
248 commits 1 branch 0 tags 2.8 MiB
Commit graph

248 commits

This branch
This branch
All branches
Author SHA1 Message Date
Octol1ttle
a326adb680
Fix Reminder serialization/deserialization (#166) 
Closes #124 

Before we dive into this PR, let's explain a few rules of serialization
and deserialization in System.Text.Json (often referred as STJ).

The important rule of serialization is that fields are ***not***
serialized unless the serializer gets passed an instance of
`JsonSerializerOptions` that explicitly tells it to include fields.
However, properties are serialized by default.

The important rule of ***de***serialization is that class members are
only deserialized if:
1) In case of properties, they must have a setter
2) If they do not have a setter, the constructor must have an argument,
required or optional, that will act as the setter for that property.

Unfortunately, both of these rules were ignored in some commit that
refactored reminders. This PR is here to fix that issue by:
1) Converting fields in `Reminder.cs` to properties
2) Adding an optional argument to the `MemberData` constructor
 2023-10-17 17:01:24 +05:00
Octol1ttle
67d44ff835
Sanitize input text in message edit log (#162) 
This PR fixes an issue that caused syntax highlighting to be applied to
incorrect lines in the message edit log. The fix is to prepend a
zero-width space before every line of input text. This prevents Discord
from highlighting the line when it wasn't edited
 2023-10-12 21:51:51 +05:00
Octol1ttle
e6f53b13f0
Split extension methods into separate classes (#161) 
This PR splits the extension methods contained in `Extensions.cs` into
separate classes in the `Octobot.Extensions` namespace. This was done
for multiple reasons:
1) The `Extensions.cs` violates SRP (Single Responsibility Principle) -
it takes upon itself every extension method for many types
2) Having a separate class for each extended type is a standard practice
- take a look at
[Remora.Discord](https://github.com/Remora/Remora.Discord/tree/main/Backend/Remora.Discord.Rest/Extensions)
or [osu!](https://github.com/ppy/osu/tree/master/osu.Game/Extensions)
3) Having all extension methods in one file makes it hard to find the
method you want
 2023-10-12 15:37:25 +00:00
Octol1ttle
20eac79380
Correct issue label names per recent changes (#160) 
Issue labels have been reworked recently, causing some files in
`.github` to reference non-existing issue labels. This PR updates the
names of labels in these files.
 2023-10-12 17:44:13 +03:00
Macintosh II
4d526ad32f
Sanitize scheduled event names (#159) 
In this PR, I added `Markdown.Sanitize` for every `scheduledEvent.Name`
and `eventData.Name`. That means, every title in scheduled event embeds
will be sanitized.

I did that because in scheduled event list event title displays only as
sanitized string.

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-12 10:56:24 +00:00
Macintosh II
e21cefd79d
Use link button for created event message (#158) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-11 22:16:52 +03:00
Macintosh II
8b659a6582
Rename Reminder message to Reminder text (#157) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-06 14:20:18 +00:00
Macintosh II
d1e3558bc6
/remind: Switch away from zero-based numbering and rename index (#155) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-06 14:17:48 +00:00
Macintosh II
a70c228bc4
Change reminders sorting in /listremind (#156) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-06 16:12:36 +03:00
Macintosh II
4748c5de2c
Rename /showinfo to avoid confusion with /guildinfo (#153) 
Depends on #152

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-06 15:35:08 +03:00
Macintosh II
72f728323e
Add /guildinfo (#152) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-06 15:23:45 +03:00
Octol1ttle
6f1e543edb
Correct illegal nickname characters regex (#151) 
Apparently there are non-letter characters in between A-Z and a-z
 2023-10-04 21:55:39 +05:00
Macintosh II
8a27aae2b7
Update .gitignore (#150) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-04 21:49:21 +05:00
Octol1ttle
2ab020a2b4
Change IUser variable and parameter names to be less confusing (#149) 
note: there are still instances of `IUser user` because I could not find
a better name for them

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-10-04 15:21:10 +00:00
Macintosh II
d27168a89f
Add building & running instructions (#148) 
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-04 18:18:59 +03:00
Macintosh II
f7b59c173f
Use one common method in /mute (#145) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-04 13:27:05 +00:00
Macintosh II
395a656fc2
Edit log output in GuildLoadedResponder (#147) 
Depends on #146

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-04 13:01:26 +00:00
Macintosh II
68d1534b26
Unload guild datas when they become unavailable (#146) 
Closes #120

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-04 15:58:56 +03:00
Macintosh II
777dbc6eec
Update /random (#138) 
Updates in /random:
- Set default minimum number to 0.
- Show maximum & minimum numbers.
- Recolor & display a message when user tries to use exact same number in first and second fields for some reason.
- Mention user in small title.
- Automatically detect max & min numbers.
- Add `long` support.
- Show what default number is.

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
Signed-off-by: Apceniy <53149450+Apceniy@users.noreply.github.com>
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Co-authored-by: Apceniy <53149450+Apceniy@users.noreply.github.com>
 2023-10-04 15:32:54 +03:00
Macintosh II
7cf200d8de
Fix /unmute not checking if the target is muted (#143) 
Closes #142

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-03 17:25:28 +03:00
Octol1ttle
bae92fc84b
Remove unused messages (#144) 2023-10-03 13:27:27 +00:00
Macintosh II
413b8a4781
Add /timestamp (#140) 
Original idea from @Octol1ttle

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-03 15:07:41 +03:00
Octol1ttle
74a287ba72
fix(i18n): [RU] do not use colloquialisms in ReminderText (#141) 2023-10-03 14:55:58 +03:00
Macintosh II
d837745b11
Add string interpolation for SongUpdateService (#139) 
I added a string interpolation for SongUpdateService for
better activity status configuration. So now you can add some characters
if you want, or even swap the song title and author.

Also songs are now displaying in Splatoon™ style.

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-02 17:41:43 +03:00
Macintosh II
186eb65eb1
Add MORE Splatoon™ songs that I liked (#135) 
Song list:
- Off the Hook - Muck Warfare — [source](https://youtu.be/Se3AuyS-gTo)
- Off the Hook - Acid Hues — [source](https://youtu.be/RoBhJth2VZE)
- Off the Hook - Shark Bytes — [source](https://youtu.be/YrGSrxDRAXU)
- DJ Octavio feat. Squid Sisters & Deep Cut - Calamari Inkantation 3MIX
— [source](https://youtu.be/_TE22RCxCi4)
- Splatoon - Ink Me Up —
[source](https://www.youtube.com/watch?v=LrsAKUnb3Qg)

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-01 10:57:25 +03:00
Macintosh II
67ef6b7209
Make README slightly better (#136) 
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-01 10:06:50 +03:00
Octol1ttle
9323e891a1
Remove all non-Splatoon songs (#137) 2023-10-01 12:04:00 +05:00
Octol1ttle
6247a55a35
Use Snowflake#Empty extension method instead of '== 0' checks (#134) 2023-09-30 15:53:05 +00:00
Octol1ttle
e283ba5a6d
Don't forget to remove scheduled event data when notification channel is not set (#133) 
This PR fixes an issue that caused data of completed/cancelled scheduled
events to never be collected if EventNotificationChannel wasn't set
 2023-09-30 20:50:58 +05:00
Octol1ttle
f3da876d6d
Run scheduled event updates synchronously to avoid a rate limit error (#132) 
This PR attempts to fix this error:
https://paste.gg/p/anonymous/358d5b1b80b44011b7afe5007270b175 based on
the assumption that the error is caused by a race condition affecting
the rate limit tracking code in Remora.Discord
 2023-09-30 20:41:46 +05:00
Octol1ttle
e073c5a572
Synchronize events only on sch. event updates (#131) 
This PR moves all code related to synchronization of scheduled events to
ScheduledEventUpdateService. Just like #130, this reduces possible
points of failures, maintenance burden and reliance on gateway events
 2023-09-30 15:38:52 +00:00
Octol1ttle
d713b977f0
Synchronize roles only on member data updates (#130) 
This PR makes it so that roles in MemberData are updated only in
MemberUpdateService. This reduces possible points of failures,
maintenance burden and reliance on gateway events
 2023-09-30 20:36:55 +05:00
Octol1ttle
5d278883d5
Synchronize scheduled events on sch. events tick (#129) 
Because the Discord API sucks at providing data when needed, this PR
makes it so that events are synchronized every tick instead of on
gateway events. This fixes an issue where the bot won't know about a
scheduled event if it was created before the bot was started
 2023-09-30 20:25:22 +05:00
Macintosh II
804bcd6e68
Rebrand to Octobot (#128) 
We're moving!

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-30 18:58:32 +05:00
Macintosh II
2e2f50908e
Add /random (#127) 
It could have been a milestone PR, but of course I made a mistake
_somewhere_.

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-29 16:22:44 +00:00
Macintosh II
04897cab20
Redesign embeds (#123) 
TODO before merging:

- [x] /about
- [x] /ban
- [x] /unban
- [x] /kick
- [x] /mute
- [x] /unmute
- [x] /remind
- [x] /listremind
- [x] MessageEditedResponder
- [x] MessageDeletedResponder

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-29 18:36:16 +03:00
Macintosh II
d5c4340210
Add some Splatoon™ songs that I liked (#125) 
- Deep Cut - Big Betrayal —
[source](https://www.youtube.com/watch?v=BMy7gvl3bXE)
- Squid Sisters - Tommorrow's Nostalgia Today —
[source](https://www.youtube.com/watch?v=S8VYi2ODeF4)
- Deep Cut - Anarchy Rainbow —
[source](https://www.youtube.com/watch?v=DtMOAvOWTvY)
- Squid Sisters - Liquid Sunshine —
[source](https://www.youtube.com/watch?v=EZx61kSObTIg)
- Damp Socks feat. Off the Hook - Candy-Coated Rocks —
[source](https://youtube.com/watch?v=_-nyDSANZt4)
- H2Whoa - Aquasonic —
[source](https://www.youtube.com/watch?v=t2sNgpFgFC0)
- Yoko & the Gold Bazookas - Ska-Blam! —
[source](https://www.youtube.com/watch?v=9pHIwuTHcbc)

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-29 15:50:15 +03:00
Macintosh II
0f916d46de
Add /showinfo (#122) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-29 15:31:45 +03:00
Macintosh II
4e4e60f845
Fix mute role returning when rejoining server (#121) 
Closes #117

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-28 14:26:58 +03:00
Octol1ttle
e907930623
Fix auto-unban and auto-unmute always triggering (#119) 
Flipping `>` to `<=` changed null handling semantics within the
operator, causing the unban/unmute code to always run

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-28 00:07:46 +05:00
Macintosh II
906bfd07e8
Skip refreshing roles if the member is role-muted (#118) 
Closes #116
 2023-09-27 18:27:28 +00:00
Macintosh II
f2db7f016c
Fix UnknownMember warning flood (#115) 
If a user was muted using the `MuteRole` method and then banned, the
UnknownMember warning will flood your logs when `DateTimeOffset.UtcNow >
data.MutedUntil` becomes true, because there is no user in the server to
unmute.

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-09-27 21:25:49 +03:00
Macintosh II
1ab5a640a9
Set MemberData.BannedUntil to null in /unban (#114) 
Please keep `MemberData` clean of unnecessary values.

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-09-27 12:47:43 +03:00
Macintosh II
3a3865ba3d
Add /resetsettings (#111) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-22 20:23:08 +03:00
Macintosh II
d6e1468f3e
Disable the logging of SaveAsync due to spam in the logs (#113) 
Closes #112

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-22 20:09:22 +03:00
Macintosh II
81099fad4c
Move all GuildData to one folder (#110) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-22 15:33:14 +03:00
Macintosh II
1e8b7e5373
Add mute role support & fix /unmute (#109) 
- Added support for `MuteRole`, now if you add any role to this setting,
then try to mute a member, all his roles will be removed except for the
one you set in this setting.
- Fixed `/unmute`, that tried to set target's display name to unmute
reason.

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-21 20:16:09 +03:00
Macintosh II
b796b885a1
Change logo CDN (#108) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-19 06:23:02 +05:00
Macintosh II
1225ff83d4
Add MORE music to the bot (#107) 
Music added:
- EDWXRDX - CONSCIENCE (2:16)
- dontleaveme - afterward (2:29)
- Clams Casino - I'm God (4:37)
- Jupyter - Starboy (2:35)
- VØJ, Narvent - Memory Reboot (3:29)

Timecode source: [Yandex.Music](https://music.yandex.ru)

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-09-18 16:24:55 +05:00
Octol1ttle
438ecfb41b
Force enumeration of global collections before using them (#106) 
This PR closes #105 

This PR fixes exceptions caused by changing a collection's contents
while it is being enumerated. This can often happen with Guild- and
MemberDatas. By using `ToArray()` on these global collections and using
it in the `foreach` loop, we create a new copy of the collection,
preventing any modification to it.

While this does introduce a lot of memory allocations, there is no
fixing that. Usually, the fix to these exceptions would be to convert
the `foreach` to a reverse-`for`. However, because indices cannot be
used on these collections, that is not possible.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-12 16:28:46 +03:00