TeamInklings/OctobotStealth
TeamInklings/OctobotStealth
Archived
1
0
Fork 0
forked from TeamInklings/Octobot
Code Pull requests Wiki Activity Actions
189 commits 1 branch 0 tags 2.8 MiB
Commit graph

73 commits

Author SHA1 Message Date
Macintosh II
4748c5de2c
Rename /showinfo to avoid confusion with /guildinfo (#153) 
Depends on #152

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-06 15:35:08 +03:00
Macintosh II
72f728323e
Add /guildinfo (#152) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-06 15:23:45 +03:00
Octol1ttle
6f1e543edb
Correct illegal nickname characters regex (#151) 
Apparently there are non-letter characters in between A-Z and a-z
 2023-10-04 21:55:39 +05:00
Octol1ttle
2ab020a2b4
Change IUser variable and parameter names to be less confusing (#149) 
note: there are still instances of `IUser user` because I could not find
a better name for them

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-10-04 15:21:10 +00:00
Macintosh II
f7b59c173f
Use one common method in /mute (#145) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-04 13:27:05 +00:00
Macintosh II
395a656fc2
Edit log output in GuildLoadedResponder (#147) 
Depends on #146

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-04 13:01:26 +00:00
Macintosh II
68d1534b26
Unload guild datas when they become unavailable (#146) 
Closes #120

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-04 15:58:56 +03:00
Macintosh II
777dbc6eec
Update /random (#138) 
Updates in /random:
- Set default minimum number to 0.
- Show maximum & minimum numbers.
- Recolor & display a message when user tries to use exact same number in first and second fields for some reason.
- Mention user in small title.
- Automatically detect max & min numbers.
- Add `long` support.
- Show what default number is.

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
Signed-off-by: Apceniy <53149450+Apceniy@users.noreply.github.com>
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Co-authored-by: Apceniy <53149450+Apceniy@users.noreply.github.com>
 2023-10-04 15:32:54 +03:00
Macintosh II
7cf200d8de
Fix /unmute not checking if the target is muted (#143) 
Closes #142

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-03 17:25:28 +03:00
Octol1ttle
bae92fc84b
Remove unused messages (#144) 2023-10-03 13:27:27 +00:00
Macintosh II
413b8a4781
Add /timestamp (#140) 
Original idea from @Octol1ttle

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-03 15:07:41 +03:00
Macintosh II
d837745b11
Add string interpolation for SongUpdateService (#139) 
I added a string interpolation for SongUpdateService for
better activity status configuration. So now you can add some characters
if you want, or even swap the song title and author.

Also songs are now displaying in Splatoon™ style.

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-02 17:41:43 +03:00
Macintosh II
186eb65eb1
Add MORE Splatoon™ songs that I liked (#135) 
Song list:
- Off the Hook - Muck Warfare — [source](https://youtu.be/Se3AuyS-gTo)
- Off the Hook - Acid Hues — [source](https://youtu.be/RoBhJth2VZE)
- Off the Hook - Shark Bytes — [source](https://youtu.be/YrGSrxDRAXU)
- DJ Octavio feat. Squid Sisters & Deep Cut - Calamari Inkantation 3MIX
— [source](https://youtu.be/_TE22RCxCi4)
- Splatoon - Ink Me Up —
[source](https://www.youtube.com/watch?v=LrsAKUnb3Qg)

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-01 10:57:25 +03:00
Octol1ttle
9323e891a1
Remove all non-Splatoon songs (#137) 2023-10-01 12:04:00 +05:00
Octol1ttle
6247a55a35
Use Snowflake#Empty extension method instead of '== 0' checks (#134) 2023-09-30 15:53:05 +00:00
Octol1ttle
e283ba5a6d
Don't forget to remove scheduled event data when notification channel is not set (#133) 
This PR fixes an issue that caused data of completed/cancelled scheduled
events to never be collected if EventNotificationChannel wasn't set
 2023-09-30 20:50:58 +05:00
Octol1ttle
f3da876d6d
Run scheduled event updates synchronously to avoid a rate limit error (#132) 
This PR attempts to fix this error:
https://paste.gg/p/anonymous/358d5b1b80b44011b7afe5007270b175 based on
the assumption that the error is caused by a race condition affecting
the rate limit tracking code in Remora.Discord
 2023-09-30 20:41:46 +05:00
Octol1ttle
e073c5a572
Synchronize events only on sch. event updates (#131) 
This PR moves all code related to synchronization of scheduled events to
ScheduledEventUpdateService. Just like #130, this reduces possible
points of failures, maintenance burden and reliance on gateway events
 2023-09-30 15:38:52 +00:00
Octol1ttle
d713b977f0
Synchronize roles only on member data updates (#130) 
This PR makes it so that roles in MemberData are updated only in
MemberUpdateService. This reduces possible points of failures,
maintenance burden and reliance on gateway events
 2023-09-30 20:36:55 +05:00
Octol1ttle
5d278883d5
Synchronize scheduled events on sch. events tick (#129) 
Because the Discord API sucks at providing data when needed, this PR
makes it so that events are synchronized every tick instead of on
gateway events. This fixes an issue where the bot won't know about a
scheduled event if it was created before the bot was started
 2023-09-30 20:25:22 +05:00
Macintosh II
804bcd6e68
Rebrand to Octobot (#128) 
We're moving!

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-30 18:58:32 +05:00
Macintosh II
2e2f50908e
Add /random (#127) 
It could have been a milestone PR, but of course I made a mistake
_somewhere_.

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-29 16:22:44 +00:00
Macintosh II
04897cab20
Redesign embeds (#123) 
TODO before merging:

- [x] /about
- [x] /ban
- [x] /unban
- [x] /kick
- [x] /mute
- [x] /unmute
- [x] /remind
- [x] /listremind
- [x] MessageEditedResponder
- [x] MessageDeletedResponder

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-29 18:36:16 +03:00
Macintosh II
d5c4340210
Add some Splatoon™ songs that I liked (#125) 
- Deep Cut - Big Betrayal —
[source](https://www.youtube.com/watch?v=BMy7gvl3bXE)
- Squid Sisters - Tommorrow's Nostalgia Today —
[source](https://www.youtube.com/watch?v=S8VYi2ODeF4)
- Deep Cut - Anarchy Rainbow —
[source](https://www.youtube.com/watch?v=DtMOAvOWTvY)
- Squid Sisters - Liquid Sunshine —
[source](https://www.youtube.com/watch?v=EZx61kSObTIg)
- Damp Socks feat. Off the Hook - Candy-Coated Rocks —
[source](https://youtube.com/watch?v=_-nyDSANZt4)
- H2Whoa - Aquasonic —
[source](https://www.youtube.com/watch?v=t2sNgpFgFC0)
- Yoko & the Gold Bazookas - Ska-Blam! —
[source](https://www.youtube.com/watch?v=9pHIwuTHcbc)

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-29 15:50:15 +03:00
Macintosh II
0f916d46de
Add /showinfo (#122) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-29 15:31:45 +03:00
Macintosh II
4e4e60f845
Fix mute role returning when rejoining server (#121) 
Closes #117

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-28 14:26:58 +03:00
Octol1ttle
e907930623
Fix auto-unban and auto-unmute always triggering (#119) 
Flipping `>` to `<=` changed null handling semantics within the
operator, causing the unban/unmute code to always run

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-28 00:07:46 +05:00
Macintosh II
906bfd07e8
Skip refreshing roles if the member is role-muted (#118) 
Closes #116
 2023-09-27 18:27:28 +00:00
Macintosh II
f2db7f016c
Fix UnknownMember warning flood (#115) 
If a user was muted using the `MuteRole` method and then banned, the
UnknownMember warning will flood your logs when `DateTimeOffset.UtcNow >
data.MutedUntil` becomes true, because there is no user in the server to
unmute.

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-09-27 21:25:49 +03:00
Macintosh II
1ab5a640a9
Set MemberData.BannedUntil to null in /unban (#114) 
Please keep `MemberData` clean of unnecessary values.

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-09-27 12:47:43 +03:00
Macintosh II
3a3865ba3d
Add /resetsettings (#111) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-22 20:23:08 +03:00
Macintosh II
d6e1468f3e
Disable the logging of SaveAsync due to spam in the logs (#113) 
Closes #112

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-22 20:09:22 +03:00
Macintosh II
81099fad4c
Move all GuildData to one folder (#110) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-22 15:33:14 +03:00
Macintosh II
1e8b7e5373
Add mute role support & fix /unmute (#109) 
- Added support for `MuteRole`, now if you add any role to this setting,
then try to mute a member, all his roles will be removed except for the
one you set in this setting.
- Fixed `/unmute`, that tried to set target's display name to unmute
reason.

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-21 20:16:09 +03:00
Macintosh II
b796b885a1
Change logo CDN (#108) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-19 06:23:02 +05:00
Macintosh II
1225ff83d4
Add MORE music to the bot (#107) 
Music added:
- EDWXRDX - CONSCIENCE (2:16)
- dontleaveme - afterward (2:29)
- Clams Casino - I'm God (4:37)
- Jupyter - Starboy (2:35)
- VØJ, Narvent - Memory Reboot (3:29)

Timecode source: [Yandex.Music](https://music.yandex.ru)

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-09-18 16:24:55 +05:00
Octol1ttle
438ecfb41b
Force enumeration of global collections before using them (#106) 
This PR closes #105 

This PR fixes exceptions caused by changing a collection's contents
while it is being enumerated. This can often happen with Guild- and
MemberDatas. By using `ToArray()` on these global collections and using
it in the `foreach` loop, we create a new copy of the collection,
preventing any modification to it.

While this does introduce a lot of memory allocations, there is no
fixing that. Usually, the fix to these exceptions would be to convert
the `foreach` to a reverse-`for`. However, because indices cannot be
used on these collections, that is not possible.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-12 16:28:46 +03:00
Octol1ttle
31968837e5
Fix JSON corruption when saving (#100) 
This PR fixes an issue that caused guild data JSON files to be corrupted
upon saving. As it turns out `File.OpenWrite(string)` does not clear the
file before writing to it. That means, if a file contains `{"MyKey":
"MyValue"}` and I write `{}` to it using `File.OpenWrite(string)`, the
contents of the file will be `{}MyKey": "MyValue"}`. This is a malformed
JSON and will cause an error upon next bot startup.

In addition, this PR blacklists the `File.OpenWrite` method using
`CodeAnalysis/BannedSymbols.txt` to prevent its accidental use in the
future.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-08-22 07:46:57 +00:00
Octol1ttle
5831f5205c
Add autocomplete for /editsettings setting keys (#98) 
This PR adds autocomplete for setting keys in `/editsetting` slash
command. The usage of options provided by auto-complete is enforced
client-side.

Closes #97
Closes #95

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-08-22 07:45:46 +00:00
Octol1ttle
37ebf0ffa0
Add periodic guild data saving (every 5 minutes) (#99) 
This PR adds a BackgroundGuildDataSaverService which will save all guild
data to disk every 5 minutes using a PeriodicTimer.

Closes #96

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-08-22 07:44:05 +00:00
Octol1ttle
324f455404
Rename settings commands (#94) 
This PR renames commands `/settingslist` and `/settings` to
`/listsettings` and `/editsettings` respectively. This helps avoid
confusion and accidental use of the wrong command while conforming to a
common naming style, similar to remind commands.

cc @mctaylors wiki needs updating

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-08-22 02:18:58 +03:00
Macintosh II
5937fae552
Change organization name references from TeamOctolings to LabsDevelopment (#93) 
we are moving!

(6 commits because I was too lazy to open the IDE)

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-08-20 20:27:16 +00:00
Octol1ttle
0bf61ecf39
Add a JSON deserialization constructor for ScheduledEventData (#92) 
This PR fixes an exception that would occur when deserialization of
ScheduledEventData would be attempted. The exception is fixed by
providing a constructor containing all properties and adding the
`[JsonConstructor]` attribute.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-08-15 05:23:58 +00:00
Octol1ttle
4252613dd3
Fix various issues with ScheduledEventUpdateService (#89) 
This PR closes #85.

This PR fixes many issues related to scheduled events. Most importantly,
scheduled events that are no longer present in the guild, but still have
data related to them, won't be left rotting.

This requires deletion of `ScheduledEvents.json` files in all guilds.
Maybe I'll start writing datafixers one day...

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-08-14 13:24:22 +00:00
Macintosh II
da2a88246c
Add failed embed for /listremind (#88) 
Without this embed, if there are no reminders created by the user, the
bot will endlessly think because StringBuilder will be empty and normal
embed will not be shown.
 2023-08-14 07:45:56 +00:00
Macintosh II
87dbb07dec
EventEarlyNotification timestamp bugfix and other changes (#84) 
This PR fixes EventEarlyNotification timestamp not displaying correctly
and also has some other changes:
- Add xmldocs for `/settingslist`'s `page` option in
SettingsCommandGroup.cs
- Add option description for `index` for `/delreminder`
- Some corrections of grammatical errors in Messages.tt-ru.resx
- Fix `ArgumentOutOfRangeException` in `/settingslist` that appears if
the user uses a negative integer in `page`

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-08-12 20:19:07 +00:00
Octol1ttle
d0d663d2bb
Fix a crash in scheduled event early notification (#83) 
This PR fixes a fatal crash that occurs when the bot tries to send an
early notification for a scheduled event. An exception is thrown by
`string#Format` when the argument list provided doesn't match the
argument list in the template. This is fixed by correcting the template
and the argument list

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-08-12 14:18:30 +00:00
Octol1ttle
488a1eec0c
Add /listremind and /delremind (#82) 
This PR closes #61.

This PR adds the `/listremind` command and the `/delremind` command. The
`/delremind` command requires an index to determine which reminder to
delete.

cc @mctaylors review embed design and feature experience

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-08-12 13:54:51 +00:00
Octol1ttle
cac3ee9bf7
Scheduled event update bugfixes (#81) 
This PR fixes the following bugs in ScheduledEventUpdateService:
- When a scheduled event is first added into ScheduledEventData, its
status update code will be skipped. This results in some messages not
being sent to the EventNotificationChannel
- When the status update code returns an unsuccessful Result, the status
in ScheduledEventData will still be updated, meaning that the code will
not retry.

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-08-12 13:47:14 +00:00
Octol1ttle
f260681b39
Split GuildUpdateService into separate services (#80) 
GuildUpdateService is a service that contains way too many
responsibilities with everything strictly coupled to each other. The
code is buggy, hard to refactor and swallows errors. This prompted me to
make this PR, which splits it into three independant services:
- SongUpdateService (responsible for changing songs presence);
- MemberUpdateService (responsible for updating member datas: unbanning
users, adding the default role, sending reminders, filtering nicknames);
- ScheduledEventUpdateService (responsible for updating scheduled
events: sending notifications, automatically starting events).

All of these services and their methods use Results to push errors all
the way up in the stack, making sure no error is missed. To make logging
and debugging easier, an extension method for `ILogger` was created -
`LogResult`. The method checks if the result was successful or if its
failure was caused by a user or environment error before logging
anything - providing cleaner code and logs. `ExceptionError`s will also
have their exception stacktrace and type logged (except in Remora code).

This PR also fixes an issue that prevented banned users from being
unbanned when their punishment was over.

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-08-05 18:02:40 +00:00