Make LogAction return void ()

1) the method isn't actually async lulw
2) it always returns success, so might as well just be void

reduces complexity by a bit

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
This commit is contained in:
Octol1ttle 2024-02-06 23:39:20 +05:00 committed by GitHub
parent 58bd439aa7
commit d39303560d
Signed by: GitHub
GPG key ID: B5690EEEBB952194
6 changed files with 12 additions and 39 deletions
src/Services

View file

@ -196,7 +196,7 @@ public sealed class Utility
/// </param>
/// <param name="ct">The cancellation token for this operation.</param>
/// <returns>A result which has succeeded.</returns>
public Result LogActionAsync(
public void LogAction(
JsonNode cfg, Snowflake channelId, IUser user, string title, string description, IUser avatar,
Color color, bool isPublic = true, CancellationToken ct = default)
{
@ -205,7 +205,7 @@ public sealed class Utility
if (GuildSettings.PublicFeedbackChannel.Get(cfg).EmptyOrEqualTo(channelId)
&& GuildSettings.PrivateFeedbackChannel.Get(cfg).EmptyOrEqualTo(channelId))
{
return Result.FromSuccess();
return;
}
var logEmbed = new EmbedBuilder().WithSmallTitle(title, avatar)
@ -230,8 +230,6 @@ public sealed class Utility
privateChannel, embedResult: logEmbed,
ct: ct);
}
return Result.FromSuccess();
}
public async Task<Result<Snowflake>> GetEmergencyFeedbackChannel(IGuild guild, GuildData data, CancellationToken ct)