TeamInklings/OctobotStealth
TeamInklings/OctobotStealth
Archived
1
0
Fork 0
forked from TeamInklings/Octobot
Code Pull requests Wiki Activity Actions

Add autocomplete for /editsettings setting keys (#98)

Browse source 
This PR adds autocomplete for setting keys in `/editsetting` slash
command. The usage of options provided by auto-complete is enforced
client-side.

Closes #97
Closes #95

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
This commit is contained in:
Octol1ttle 2023-08-22 12:45:46 +05:00 committed by GitHub
parent 37ebf0ffa0
commit 5831f5205c
Signed by: GitHub
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 40 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/Commands/SettingsCommandGroup.cs
View file

@ -26,6 +26,13 @@ namespace Boyfriend.Commands;
[UsedImplicitly] [UsedImplicitly]
public class SettingsCommandGroup : CommandGroup public class SettingsCommandGroup : CommandGroup
{ {
/// <summary>
/// Represents all options as an array of objects implementing <see cref="IOption" />.
/// </summary>
/// <remarks>
/// WARNING: If you update this array in any way, you must also update <see cref="AllOptionsEnum" /> and make sure
/// that the orders match.
/// </remarks>
private static readonly IOption[] AllOptions = private static readonly IOption[] AllOptions =
{ {
GuildSettings.Language, GuildSettings.Language,
@ -158,7 +165,7 @@ public class SettingsCommandGroup : CommandGroup
[UsedImplicitly] [UsedImplicitly]
public async Task<Result> ExecuteEditSettingsAsync( public async Task<Result> ExecuteEditSettingsAsync(
[Description("The setting whose value you want to change")] [Description("The setting whose value you want to change")]
string setting, AllOptionsEnum setting,
[Description("Setting value")] string value) [Description("Setting value")] string value)
{ {
if (!_context.TryGetContextIDs(out var guildId, out var channelId, out var userId)) if (!_context.TryGetContextIDs(out var guildId, out var channelId, out var userId))
@ -181,16 +188,14 @@ public class SettingsCommandGroup : CommandGroup
var data = await _guildData.GetData(guildId, CancellationToken); var data = await _guildData.GetData(guildId, CancellationToken);
Messages.Culture = GuildSettings.Language.Get(data.Settings); Messages.Culture = GuildSettings.Language.Get(data.Settings);
return await EditSettingAsync(setting, value, data, channelId, user, currentUser, CancellationToken); return await EditSettingAsync(AllOptions[(int)setting], value, data, channelId, user, currentUser,
CancellationToken);
} }
private async Task<Result> EditSettingAsync( private async Task<Result> EditSettingAsync(
string setting, string value, GuildData data, Snowflake channelId, IUser user, IUser currentUser, IOption option, string value, GuildData data, Snowflake channelId, IUser user, IUser currentUser,
CancellationToken ct = default) CancellationToken ct = default)
{ {
var option = AllOptions.Single(
o => string.Equals(setting, o.Name, StringComparison.InvariantCultureIgnoreCase));
var setResult = option.Set(data.Settings, value); var setResult = option.Set(data.Settings, value);
if (!setResult.IsSuccess) if (!setResult.IsSuccess)
{ {

29
src/Data/Options/AllOptionsEnum.cs Normal file
View file

@ -0,0 +1,29 @@
using Boyfriend.Commands;
using JetBrains.Annotations;
namespace Boyfriend.Data.Options;
/// <summary>
/// Represents all options as enums.
/// </summary>
/// <remarks>
/// WARNING: This enum is order-dependent! It's values are used as indexes for
/// <see cref="SettingsCommandGroup.AllOptions" />.
/// </remarks>
public enum AllOptionsEnum
{
[UsedImplicitly] Language,
[UsedImplicitly] WelcomeMessage,
[UsedImplicitly] ReceiveStartupMessages,
[UsedImplicitly] RemoveRolesOnMute,
[UsedImplicitly] ReturnRolesOnRejoin,
[UsedImplicitly] AutoStartEvents,
[UsedImplicitly] RenameHoistedUsers,
[UsedImplicitly] PublicFeedbackChannel,
[UsedImplicitly] PrivateFeedbackChannel,
[UsedImplicitly] EventNotificationChannel,
[UsedImplicitly] DefaultRole,
[UsedImplicitly] MuteRole,
[UsedImplicitly] EventNotificationRole,
[UsedImplicitly] EventEarlyNotificationOffset
}