From 324f4554041a0df460fb09273fa283292da91989 Mon Sep 17 00:00:00 2001 From: Octol1ttle Date: Tue, 22 Aug 2023 04:18:58 +0500 Subject: [PATCH] Rename settings commands (#94) This PR renames commands `/settingslist` and `/settings` to `/listsettings` and `/editsettings` respectively. This helps avoid confusion and accidental use of the wrong command while conforming to a common naming style, similar to remind commands. cc @mctaylors wiki needs updating --------- Signed-off-by: Octol1ttle --- src/Commands/SettingsCommandGroup.cs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/Commands/SettingsCommandGroup.cs b/src/Commands/SettingsCommandGroup.cs index 61be402..fab90c4 100644 --- a/src/Commands/SettingsCommandGroup.cs +++ b/src/Commands/SettingsCommandGroup.cs @@ -68,16 +68,15 @@ public class SettingsCommandGroup : CommandGroup /// /// A feedback sending result which may or may not have succeeded. /// - [Command("settingslist")] + [Command("listsettings")] [DiscordDefaultMemberPermissions(DiscordPermission.ManageGuild)] [DiscordDefaultDMPermission(false)] [RequireContext(ChannelContext.Guild)] [RequireDiscordPermission(DiscordPermission.ManageGuild)] [Description("Shows settings list for this server")] [UsedImplicitly] - public async Task ExecuteSettingsListAsync( - [Description("Settings list page")] - [MinValue(1)] + public async Task ExecuteListSettingsAsync( + [Description("Settings list page")] [MinValue(1)] int page) { if (!_context.TryGetContextIDs(out var guildId, out _, out _)) @@ -150,14 +149,14 @@ public class SettingsCommandGroup : CommandGroup /// The setting to modify. /// The new value of the setting. /// A feedback sending result which may or may not have succeeded. - [Command("settings")] + [Command("editsettings")] [DiscordDefaultMemberPermissions(DiscordPermission.ManageGuild)] [DiscordDefaultDMPermission(false)] [RequireContext(ChannelContext.Guild)] [RequireDiscordPermission(DiscordPermission.ManageGuild)] [Description("Change settings for this server")] [UsedImplicitly] - public async Task ExecuteSettingsAsync( + public async Task ExecuteEditSettingsAsync( [Description("The setting whose value you want to change")] string setting, [Description("Setting value")] string value)