TeamInklings/Octobot
TeamInklings/Octobot
1
0
Fork 1
mirror of https://github.com/TeamOctolings/Octobot.git synced 2025-02-28 09:52:39 +03:00
Code Issues Wiki Activity
289 commits 4 branches 0 tags 4.5 MiB
Commit graph

72 commits

Author SHA1 Message Date
Macintxsh
e76fccd622
Rename currentMember to botMember (#291) 
Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-03-24 21:40:04 +03:00
Octol1ttle
171cfaea1a
Add 'ModeratorRole' guild setting (#290) 
Octobot has various moderation commands such as /ban, /mute, /kick.
These commands add multiple features to Discord's built-in functions
(such as durations and logging). Some admins may want to force their
users to use Octobot's commands instead of Discord UI functions.
However, due to the current design, they can't take away the permissions
as that remove access to the respective command.

This PR adds the `ModeratorRole` option which allows anyone who has
`ManageMessages` permission and the role to perform any moderator
action.

If the role is not set, the Discord permissions are checked instead. If
the user doesn't have the role, but has the permission, they can still
run the command.

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-24 23:29:10 +05:00
Octol1ttle
a80debf1b1
Use Result.Success property instead of Result.FromSuccess() (#283) 
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-21 20:55:34 +05:00
Octol1ttle
309d900067
Log result failures with stack traces (#282) 
This feature will improve the debugging experience for developers by
providing the information about *where exactly* a result has failed

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-03-20 18:08:16 +00:00
Macintxsh
1894b063ae
Fix auto-unban log spam (#271) 
Closes #255

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2024-03-18 21:26:04 +03:00
Octol1ttle
d39303560d
Make LogAction return void (#261) 
1) the method isn't actually async lulw
2) it always returns success, so might as well just be void

reduces complexity by a bit

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2024-02-06 18:39:20 +00:00
Octol1ttle
58bd439aa7
Revert "Add profiler base" (#260) 
Reverts TeamOctolings/Octobot#235
See #244
 2024-02-06 21:35:33 +03:00
dependabot[bot]
5483bbd203
Bump the remora group with 4 updates (#259) 2024-02-06 12:09:26 +00:00
Octol1ttle
7d9a85d815
Add profiler base (#235) 
This PR adds the base classes required for profiling code inside of
Octobot. The implementation of the profiler is similar to Minecraft,
however it is more detailed and provides per-event logs for each event.
This PR does not change any code to be profiled and this is intentional.
Changes required for profiling will come as separate PRs, one for
commands, one for responders, and one for background services.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-20 22:59:17 +05:00
Octol1ttle
21f200c988
Merge BackgroundGuildDataSaverService into GuildDataService (#239) 
Title. idk why I didn't think of this before.
Also, GuildDataService is now properly registered as an IHostedService,
so it receives start & shutdown events. So this PR gets rid of the
workaround that was needed for save-on-shutdown to function

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-20 20:08:56 +03:00
Octol1ttle
bd4c5b26da
Remove "extends IHostedService" from classes where it's not required (#236) 
Originally, these classes were services because I thought that all
DI-resolvable classes need to be services. However, this is not true, so
we can make these classes (notably Utility and GuildDataService) not
extend anything. `UtilityService` was renamed to `Utility` for
simplicity

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-20 19:33:52 +03:00
Octol1ttle
74e32dee9b
Use collection expressions in more places (#238) 
ReSharper inspections have been updated, causing new warnings to appear
in the codebase. This time, the "Use collection expressions" inspection
has been enabled for usecases where the collection is not empty. This PR
fixes the check failures caused by this inspection.
 2023-12-20 19:23:37 +03:00
Macintxsh
4dc460a269
Add issue button w/ some button updates (#221) 
In this PR, I've added a "Report an issue" button and a few more
button-related changes:
- Add "Report an issue" button
- Add icon for "Octobot's source code"
- Rename `AboutTitleRepository` to `ButtonOpenRepository`
- Rename `OpenEventInfoButton` to `ButtonOpenEventInfo` to be consistent
with other language string names
- Rename `ColorsList.cs` to `Miscellaneous.cs`
- Add public const strings in `Octobot.cs` to get repository & issues links

---------

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-17 21:35:09 +03:00
Macintxsh
541e18fff0
Add ChannelApiExtensions (#217) 
This PR adds an extension method to make it easier to pass Result<Embed> to CreateMessageAsync

---------

Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-12-17 21:47:52 +05:00
neroduckale
59c2c5eada
Add link to original message for activated reminders and /listremind (#203) 2023-12-11 23:38:26 +03:00
Macintxsh II
eeaff23fb5
Rewrite music list (#210) 
Changes:
- Use timestamps from
[Splatunes](https://splatoonwiki.org/wiki/Splatune_(Splatoon_Original_Soundtrack))
- Increase track count to 20
- Replace Calamari Inkantation 3MIX with OG Calamari Inkantation due to long
duration

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-08 16:15:44 +05:00
Macintxsh II
42ab11d253
Rename "Event details" button to "Open Event Info" (#209) 
The correct phrasing used by Discord is "Event Info"

![image](https://github.com/LabsDevelopment/Octobot/assets/95250141/8165b70d-4c81-4b85-8251-db2de6a7f4ca)

Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-08 16:06:50 +05:00
neroduckale
bcd1db8c8e
Fix inspection warnings (#208) 
Signed-off-by: neroduckale <100025711+neroduckale@users.noreply.github.com>
 2023-12-06 00:24:55 +05:00
Macintxsh II
4c50bdaff7
Bump .NET version to 8.0 (#207) 
Signed-off-by: mctaylors <cantsendmails@mctaylors.ru>
 2023-12-04 20:18:56 +05:00
dependabot[bot]
7e47c56015
Bump Microsoft.Extensions.Hosting from 7.0.1 to 8.0.0 (#187) 
Bumps [Microsoft.Extensions.Hosting](https://github.com/dotnet/runtime)
from 7.0.1 to 8.0.0.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-11-22 14:27:55 +05:00
Octol1ttle
e65c7a469d
Use TryGetValue instead of ContainsKey + index access to avoid double lookup (#193) 
This PR fixes an issue that is currently causing CI to fail in all pull
requests:
`Notice: "[CA1854] Prefer a 'TryGetValue' call over a Dictionary indexer
access guarded by a 'ContainsKey' check to avoid double lookup" on
/home/runner/work/Octobot/Octobot/src/Services/Update/ScheduledEventUpdateService.cs(107,4168)`
The issue is resolved by following the advice mentioned in the notice.
 2023-11-22 11:19:45 +03:00
Octol1ttle
f12d6d13c5
Check interactions in MemberUpdateService before operating on members (#177) 
This PR fixes an issue that caused REST errors to occur in
MemberUpdateService if the bot tries to interact with a member it can't
interact with. The issue is fixed by returning from TickMemberDataAsync
early if the member cannot be interacted with. An error message was
planned, but it requires adding a lot of services and severely
increasing the complexity. Contributors may feel free to add one if they
deem so necessary.
 2023-11-04 23:33:37 +05:00
Octol1ttle
cf7007f269
Handle guild data load errors better (#172) 
Previously, any errors in guild data load will cause the bot to be
unusable in that guild. It didn't help that the end users had no
information that something was wrong! Now, any errors will be logged
better (with the full path to the file that couldn't be loaded), and the
users will receive a message saying that functionality is degraded

The old way to save objects was to serialize them directly into streams
opened by `File#Create`. This can cause problems if the serialization
isn't completed, because `File#Create` overwrites the file with an empty
one on the spot. Now, objects are first deserialized into a temporary
file, then the original is replaced by the temporary, then the temporary
is deleted.

Errors during guild data load would sometimes cause the bot to replace
the corrupted file with a default one whenever a save is triggered. Now,
guilds with load errors won't have their data saved to aid in debugging

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
Signed-off-by: mctaylors <mctaylxrs@outlook.com>
 2023-10-26 18:14:27 +03:00
Octol1ttle
fead92129d
Unschedule scheduled event status update only if last update was successful (#168) 
This PR fixes an issue that prevented scheduled event status updates
from running again if they failed. This happened because, before each
update, the events would be synchronized. The `ScheduleOnStatusUpdated`
field would be set even if it's already `true`, which will cause it to
be set to `false` for unsuccessful updates. The issue is fixed by
surrounding the field set call with a condition that will prevent
setting the field from `true` to `false`
 2023-10-17 12:25:15 +00:00
Octol1ttle
580cd24810
Do not try to send messages in empty EventNotificationChannels (#167) 
This PR fixes an error that would occur if an event was created, was
about to start or started and the EventNotificationChannel was empty.
 2023-10-17 12:23:14 +00:00
Octol1ttle
687883bbf8
Use MemberData to determine a subscriber's role list (#165) 
Closes #163 

Discord's API sucks a lot. You ask it for a member, but it won't give
you a member. This is why this PR updates the
`GetEventNotificationMentions` method used to determine what roles and
users should get pinged for a scheduled event. Previously, the bot asked
Discord to provide the member for each subscriber to determine whether
or not they have the event notification role (to avoid pinging people
personally when the role would already ping them). With this pull
request, the bot uses MemberData, it's own member storage, for that
purpose (if you're wondering why, refer to the first two sentences)
 2023-10-17 12:07:01 +00:00
Octol1ttle
e6f53b13f0
Split extension methods into separate classes (#161) 
This PR splits the extension methods contained in `Extensions.cs` into
separate classes in the `Octobot.Extensions` namespace. This was done
for multiple reasons:
1) The `Extensions.cs` violates SRP (Single Responsibility Principle) -
it takes upon itself every extension method for many types
2) Having a separate class for each extended type is a standard practice
- take a look at
[Remora.Discord](https://github.com/Remora/Remora.Discord/tree/main/Backend/Remora.Discord.Rest/Extensions)
or [osu!](https://github.com/ppy/osu/tree/master/osu.Game/Extensions)
3) Having all extension methods in one file makes it hard to find the
method you want
 2023-10-12 15:37:25 +00:00
Macintosh II
4d526ad32f
Sanitize scheduled event names (#159) 
In this PR, I added `Markdown.Sanitize` for every `scheduledEvent.Name`
and `eventData.Name`. That means, every title in scheduled event embeds
will be sanitized.

I did that because in scheduled event list event title displays only as
sanitized string.

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-12 10:56:24 +00:00
Macintosh II
e21cefd79d
Use link button for created event message (#158) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-10-11 22:16:52 +03:00
Octol1ttle
6f1e543edb
Correct illegal nickname characters regex (#151) 
Apparently there are non-letter characters in between A-Z and a-z
 2023-10-04 21:55:39 +05:00
Octol1ttle
2ab020a2b4
Change IUser variable and parameter names to be less confusing (#149) 
note: there are still instances of `IUser user` because I could not find
a better name for them

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-10-04 15:21:10 +00:00
Macintosh II
68d1534b26
Unload guild datas when they become unavailable (#146) 
Closes #120

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-04 15:58:56 +03:00
Macintosh II
d837745b11
Add string interpolation for SongUpdateService (#139) 
I added a string interpolation for SongUpdateService for
better activity status configuration. So now you can add some characters
if you want, or even swap the song title and author.

Also songs are now displaying in Splatoon™ style.

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-02 17:41:43 +03:00
Macintosh II
186eb65eb1
Add MORE Splatoon™ songs that I liked (#135) 
Song list:
- Off the Hook - Muck Warfare — [source](https://youtu.be/Se3AuyS-gTo)
- Off the Hook - Acid Hues — [source](https://youtu.be/RoBhJth2VZE)
- Off the Hook - Shark Bytes — [source](https://youtu.be/YrGSrxDRAXU)
- DJ Octavio feat. Squid Sisters & Deep Cut - Calamari Inkantation 3MIX
— [source](https://youtu.be/_TE22RCxCi4)
- Splatoon - Ink Me Up —
[source](https://www.youtube.com/watch?v=LrsAKUnb3Qg)

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-10-01 10:57:25 +03:00
Octol1ttle
9323e891a1
Remove all non-Splatoon songs (#137) 2023-10-01 12:04:00 +05:00
Octol1ttle
6247a55a35
Use Snowflake#Empty extension method instead of '== 0' checks (#134) 2023-09-30 15:53:05 +00:00
Octol1ttle
e283ba5a6d
Don't forget to remove scheduled event data when notification channel is not set (#133) 
This PR fixes an issue that caused data of completed/cancelled scheduled
events to never be collected if EventNotificationChannel wasn't set
 2023-09-30 20:50:58 +05:00
Octol1ttle
f3da876d6d
Run scheduled event updates synchronously to avoid a rate limit error (#132) 
This PR attempts to fix this error:
https://paste.gg/p/anonymous/358d5b1b80b44011b7afe5007270b175 based on
the assumption that the error is caused by a race condition affecting
the rate limit tracking code in Remora.Discord
 2023-09-30 20:41:46 +05:00
Octol1ttle
e073c5a572
Synchronize events only on sch. event updates (#131) 
This PR moves all code related to synchronization of scheduled events to
ScheduledEventUpdateService. Just like #130, this reduces possible
points of failures, maintenance burden and reliance on gateway events
 2023-09-30 15:38:52 +00:00
Octol1ttle
d713b977f0
Synchronize roles only on member data updates (#130) 
This PR makes it so that roles in MemberData are updated only in
MemberUpdateService. This reduces possible points of failures,
maintenance burden and reliance on gateway events
 2023-09-30 20:36:55 +05:00
Octol1ttle
5d278883d5
Synchronize scheduled events on sch. events tick (#129) 
Because the Discord API sucks at providing data when needed, this PR
makes it so that events are synchronized every tick instead of on
gateway events. This fixes an issue where the bot won't know about a
scheduled event if it was created before the bot was started
 2023-09-30 20:25:22 +05:00
Macintosh II
804bcd6e68
Rebrand to Octobot (#128) 
We're moving!

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-30 18:58:32 +05:00
Macintosh II
d5c4340210
Add some Splatoon™ songs that I liked (#125) 
- Deep Cut - Big Betrayal —
[source](https://www.youtube.com/watch?v=BMy7gvl3bXE)
- Squid Sisters - Tommorrow's Nostalgia Today —
[source](https://www.youtube.com/watch?v=S8VYi2ODeF4)
- Deep Cut - Anarchy Rainbow —
[source](https://www.youtube.com/watch?v=DtMOAvOWTvY)
- Squid Sisters - Liquid Sunshine —
[source](https://www.youtube.com/watch?v=EZx61kSObTIg)
- Damp Socks feat. Off the Hook - Candy-Coated Rocks —
[source](https://youtube.com/watch?v=_-nyDSANZt4)
- H2Whoa - Aquasonic —
[source](https://www.youtube.com/watch?v=t2sNgpFgFC0)
- Yoko & the Gold Bazookas - Ska-Blam! —
[source](https://www.youtube.com/watch?v=9pHIwuTHcbc)

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-29 15:50:15 +03:00
Octol1ttle
e907930623
Fix auto-unban and auto-unmute always triggering (#119) 
Flipping `>` to `<=` changed null handling semantics within the
operator, causing the unban/unmute code to always run

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-28 00:07:46 +05:00
Macintosh II
906bfd07e8
Skip refreshing roles if the member is role-muted (#118) 
Closes #116
 2023-09-27 18:27:28 +00:00
Macintosh II
f2db7f016c
Fix UnknownMember warning flood (#115) 
If a user was muted using the `MuteRole` method and then banned, the
UnknownMember warning will flood your logs when `DateTimeOffset.UtcNow >
data.MutedUntil` becomes true, because there is no user in the server to
unmute.

---------

Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
 2023-09-27 21:25:49 +03:00
Macintosh II
d6e1468f3e
Disable the logging of SaveAsync due to spam in the logs (#113) 
Closes #112

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-22 20:09:22 +03:00
Macintosh II
81099fad4c
Move all GuildData to one folder (#110) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
Signed-off-by: Macintosh II <95250141+mctaylors@users.noreply.github.com>
Co-authored-by: Octol1ttle <l1ttleofficial@outlook.com>
 2023-09-22 15:33:14 +03:00
Macintosh II
1e8b7e5373
Add mute role support & fix /unmute (#109) 
- Added support for `MuteRole`, now if you add any role to this setting,
then try to mute a member, all his roles will be removed except for the
one you set in this setting.
- Fixed `/unmute`, that tried to set target's display name to unmute
reason.

---------

Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-21 20:16:09 +03:00
Macintosh II
b796b885a1
Change logo CDN (#108) 
Signed-off-by: Macintosh II <mctaylxrs@outlook.com>
 2023-09-19 06:23:02 +05:00