mirror of
https://github.com/TeamOctolings/Octobot.git
synced 2025-05-15 18:26:09 +03:00
Split extension methods into separate classes (#161)
This PR splits the extension methods contained in `Extensions.cs` into separate classes in the `Octobot.Extensions` namespace. This was done for multiple reasons: 1) The `Extensions.cs` violates SRP (Single Responsibility Principle) - it takes upon itself every extension method for many types 2) Having a separate class for each extended type is a standard practice - take a look at [Remora.Discord](https://github.com/Remora/Remora.Discord/tree/main/Backend/Remora.Discord.Rest/Extensions) or [osu!](https://github.com/ppy/osu/tree/master/osu.Game/Extensions) 3) Having all extension methods in one file makes it hard to find the method you want
This commit is contained in:
parent
20eac79380
commit
e6f53b13f0
31 changed files with 452 additions and 371 deletions
src/Extensions
19
src/Extensions/FeedbackServiceExtensions.cs
Normal file
19
src/Extensions/FeedbackServiceExtensions.cs
Normal file
|
@ -0,0 +1,19 @@
|
|||
using Remora.Discord.API.Objects;
|
||||
using Remora.Discord.Commands.Feedback.Services;
|
||||
using Remora.Results;
|
||||
|
||||
namespace Octobot.Extensions;
|
||||
|
||||
public static class FeedbackServiceExtensions
|
||||
{
|
||||
public static async Task<Result> SendContextualEmbedResultAsync(
|
||||
this FeedbackService feedback, Result<Embed> embedResult, CancellationToken ct = default)
|
||||
{
|
||||
if (!embedResult.IsDefined(out var embed))
|
||||
{
|
||||
return Result.FromError(embedResult);
|
||||
}
|
||||
|
||||
return (Result)await feedback.SendContextualEmbedAsync(embed, ct: ct);
|
||||
}
|
||||
}
|
Loading…
Add table
Add a link
Reference in a new issue