mirror of
https://github.com/TeamOctolings/Octobot.git
synced 2025-05-01 11:39:55 +03:00
General fixes (#54)
Depends on #55 These changes are really small and I don't know how to reasonably split them into multiple PRs, but here's the changelog: - The result of the `UtilityService#LogActionAsync` call in `BanCommandGroup#BanUserAsync` is no longer ignored and it's errors will now prevent feedback from being sent; - Converted `if` statement to a `return` with ternary in `LanguageOption`; - Slightly decreased method complexity of `MessageDeletedResponder#RespondAsync` by cleverly using Results; - Changed the order of parameters for `UtilityService#LogActionAsync` to flow better; - Removed the exemption for `ConvertIfToReturnStatement` for InspectCode. --------- Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
This commit is contained in:
parent
685688bbe8
commit
daa1dd4184
5 changed files with 19 additions and 20 deletions
2
.github/workflows/resharper.yml
vendored
2
.github/workflows/resharper.yml
vendored
|
@ -31,5 +31,5 @@ jobs:
|
|||
uses: muno92/resharper_inspectcode@1.7.1
|
||||
with:
|
||||
solutionPath: ./Boyfriend.sln
|
||||
ignoreIssueType: InvertIf, ConvertIfStatementToReturnStatement, ConvertIfStatementToSwitchStatement
|
||||
ignoreIssueType: InvertIf, ConvertIfStatementToSwitchStatement
|
||||
solutionWideAnalysis: true
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue