TeamInklings/Octobot
TeamInklings/Octobot
1
0
Fork 1
mirror of https://github.com/TeamOctolings/Octobot.git synced 2025-04-30 02:59:54 +03:00
Code Issues Wiki Activity

Make LogAction return void (#261)

Browse source 
1) the method isn't actually async lulw
2) it always returns success, so might as well just be void

reduces complexity by a bit

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
This commit is contained in:
Octol1ttle 2024-02-06 23:39:20 +05:00 • committed by GitHub
parent 58bd439aa7
commit d39303560d
Signed by: GitHub
GPG key ID: B5690EEEBB952194
6 changed files with 12 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/Commands/SettingsCommandGroup.cs
View file

@ -218,12 +218,8 @@ public class SettingsCommandGroup : CommandGroup
var title = Messages.SettingSuccessfullyChanged;
var description = builder.ToString();
var logResult = _utility.LogActionAsync(
_utility.LogAction(
data.Settings, channelId, executor, title, description, bot, ColorsList.Magenta, false, ct);
if (!logResult.IsSuccess)
{
return Result.FromError(logResult.Error);
}
var embed = new EmbedBuilder().WithSmallTitle(title, bot)
.WithDescription(description)